Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gigaset N720, tune code tone #184

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gigaset N720, tune code tone #184

wants to merge 4 commits into from

Conversation

BnLG
Copy link
Contributor

@BnLG BnLG commented Feb 13, 2023

Hello,

Here's a quick fix for Gigaset N720 to tune code tone.

Thank you 馃憤

@BnLG BnLG marked this pull request as draft February 13, 2023 14:39
@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@BnLG BnLG marked this pull request as ready for review February 13, 2023 15:06
@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@BnLG
Copy link
Contributor Author

BnLG commented Mar 31, 2023

@bloom1 could we please review this ?
Many thanks 馃憤

bloom1
bloom1 requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@bloom1 bloom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the delay. I have a few comments, when they will be addressed I will merge the PR 馃槃

plugins/wazo-gigaset/common/common.py Outdated Show resolved Hide resolved
plugins/wazo-gigaset/common/common.py Show resolved Hide resolved
plugins/wazo-gigaset/common/common.py Outdated Show resolved Hide resolved
@wazo-community-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

1 similar comment
@wazo-community-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@BnLG BnLG requested a review from bloom1 July 12, 2023 13:14
@BnLG
Copy link
Contributor Author

BnLG commented Jul 12, 2023

Thank you for your review @bloom1, and sorry for the delay too...
Should be OK now 馃憤

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloom1 bloom1 Awaiting requested review from bloom1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BnLG @bloom1