Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fanvil: Fix BLF index #251

Merged
merged 1 commit into from Apr 18, 2024
Merged

Fanvil: Fix BLF index #251

merged 1 commit into from Apr 18, 2024

Conversation

fouille
Copy link
Contributor

@fouille fouille commented Apr 11, 2024

  • fix BLF support type
  • fix V67 template ligne attribution

@fouille
Fix BLF index
53ccdb3 
* fix BLF support type
* fix V67 template ligne attribution
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/e456b2a39ff54d93b145da69406dbad0

✔️ wazo-tox-py39 SUCCESS in 5m 52s
✔️ wazo-tox-linters-310-provd SUCCESS in 6m 43s
✔️ wazo-provd-plugins SUCCESS in 1m 34s

@fouille fouille requested a review from bloom1 April 11, 2024 08:46
@bloom1 bloom1 changed the title Fix BLF index Fanvil: Fix BLF index Apr 11, 2024
@bloom1
Copy link
Member

bloom1 commented Apr 17, 2024

Thank you @fouille!

Have you tested if the type 1 works on all Fanvil phones for BLF keys?

@fouille
Copy link
Contributor Author

fouille commented Apr 18, 2024

Hello @bloom1
Absolutely, all devices must use type 1 as part of a BLF key otherwise it doesn't work. I think it's an impact on version 2 of the firmware. Our plugin being in this version now, we must follow this change.

bloom1
bloom1 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@bloom1 bloom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://zuul.wazo.community/zuul/t/local/buildset/e71946efea9642b5b3d122d95a705000

✔️ wazo-tox-py39 SUCCESS in 5m 43s
✔️ wazo-tox-linters-310-provd SUCCESS in 6m 32s
✔️ wazo-provd-plugins SUCCESS in 1m 29s

@wazo-community-zuul wazo-community-zuul bot merged commit b20bfb4 into master Apr 18, 2024
2 checks passed
@wazo-community-zuul wazo-community-zuul bot deleted the WP-1378 branch April 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloom1 bloom1 bloom1 approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
2 participants
@fouille @bloom1