Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple linting issues with yamllint and ansible-review #111

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

paulcalabro
Copy link
Contributor

- yamllint: "truthy value should be true or false"
   (Docs: https://github.com/adrienverge/yamllint/blob/master/yamllint/rules/truthy.py)
- ansible-review: "WARN: Best practice "Use YAML format for tasks and handlers rather than key=value" not met:"
  (Docs: https://github.com/willthames/ansible-review/blob/2aacd7462f6a8a96165d9218122171b74de54b13/lib/ansiblereview/tasks.py)
@paulcalabro paulcalabro changed the base branch from master to 3.7 December 19, 2018 12:26
@paulcalabro
Copy link
Contributor Author

In regards to the shell substitution, no piping is occurring so it's unnecessary.

If you want to execute a command securely and predictably, it may be better to use the command module instead. Best practices when writing playbooks will follow the trend of using command unless the shell module is explicitly required. When running ad-hoc commands, use your best judgement.

(Source: https://docs.ansible.com/ansible/latest/modules/shell_module.html)

Copy link
Contributor

@cadoming cadoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulcalabro,

We have tested your changes and they work correctly, soon we will merge the code. Thank you very much for your help and for improving the repository.

@jesuslinares jesuslinares merged commit 204ad3c into wazuh:3.7 Dec 27, 2018
@paulcalabro
Copy link
Contributor Author

👍

@paulcalabro paulcalabro deleted the patch-2 branch December 27, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants