Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added molecule test for the Wazuh Agent #174

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Added molecule test for the Wazuh Agent #174

merged 3 commits into from
Apr 29, 2019

Conversation

dj-wasabi
Copy link
Contributor

@dj-wasabi dj-wasabi commented Apr 27, 2019

This PR contains the following changes:

  • Added a Molecule scenario for testing the Wazuh Agent role.
  • Added various minor changes that where found during linting;

Scenario
A Molecule scenario wazuh-agent is added and starts a single Wazuh Manager on CentOS 7. Once that is done, it start 5 containers (CentOS 6+7, Ubuntu 14, 16 + 18) and install the Wazuh Agent. During the molecule verify, a test is executed on the Wazuh Manager to see if all agents are registered correctly.

linting
During executing molecule lint -s wazuh-agent, a lot of messages like the following where printed:

      71:3      error    wrong indentation: expected 4 but found 2  (indentation)
      75:21     warning  truthy value should be true or false  (truthy)
      298:247   error    trailing spaces  (trailing-spaces).
      222:6     warning  missing starting space in comment  (comments)

I had to change various file to make these lint issues disappear. Most of them where indentation errors, 1 or more spaces on the end of the line. Most of them where changing no or yes to false or true. In some of the playbooks, I had to add --- to the beginning of the file, so it is correctly yaml.

If there are any questions, don't hesitate to ask. I did not knew that the PR would be that big (58 files changed), so apologies for that.

@manuasir manuasir self-requested a review April 29, 2019 11:04
@manuasir
Copy link
Contributor

Hi @dj-wasabi ,

As always, you did an amazing and valuable job again. Much appreciated.

Regards

@manuasir manuasir added this to To Review in Wazuh 3.9.x via automation Apr 29, 2019
@manuasir manuasir merged commit 2d3ca9a into wazuh:3.9 Apr 29, 2019
Wazuh 3.9.x automation moved this from To Review to Done Apr 29, 2019
@dj-wasabi
Copy link
Contributor Author

Anytime! @manuasir 😄

@dj-wasabi dj-wasabi deleted the add-molecule-wazuh-agent branch April 29, 2019 14:08
@dj-wasabi
Copy link
Contributor Author

Thank you for merging! 👍
Already working on the next one! 😄

@manuasir manuasir mentioned this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Wazuh 3.9.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants