Set new API configuration behavior #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm404
reviewed
Jan 7, 2020
| @@ -9,6 +9,14 @@ elastic_stack_version: 7.5.1 | |||
| wazuh_version: 3.11.0 | |||
| wazuh_app_url: https://packages.wazuh.com/wazuhapp/wazuhapp | |||
|
|
|||
| # API credentials | |||
| api_auth: | |||
There was a problem hiding this comment.
I would go with wazuh_api_credentials or wazuh_api_auth and remove the api_ prefix for id url...
What are your thoughts about it?
There was a problem hiding this comment.
Well spotted. Fixed in latest commit.
jm404
reviewed
Jan 7, 2020
| status_code: 200, 404 | ||
| ignore_errors: yes | ||
|
|
||
| - name: Configure Wazuh Plugin |
There was a problem hiding this comment.
Please change it to Configure Wazuh Kibana Plugin
jm404
reviewed
Jan 7, 2020
| password: "{{ elasticsearch_xpack_security_password }}" | ||
| validate_certs: no | ||
| status_code: 200, 404 | ||
| ignore_errors: yes |
There was a problem hiding this comment.
Adding a comment to notify users that this curl can be skipped because the app does have a default config would be great IMO
There was a problem hiding this comment.
Fixed in 71e52de
Now it doesn't ignore errors on index removal
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #339
It follows the proposed workflow on the issue, deleting the
.wazuhindex if it exists.