Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic API check fix #480

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Elastic API check fix #480

merged 3 commits into from
Nov 9, 2020

Conversation

Zenidd
Copy link
Contributor

@Zenidd Zenidd commented Nov 9, 2020

Hi team,

The current Elasticsearch API test after opendistro install fails on clusters with yellow status. This PR sets yellow status as a valid one for task success.

Greetings,

JP

@Zenidd Zenidd self-assigned this Nov 9, 2020
@Zenidd Zenidd requested a review from xr09 November 9, 2020 17:33
Copy link
Contributor

@xr09 xr09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@neonmei neonmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luce bien 👍

@neonmei
Copy link
Contributor

neonmei commented Nov 9, 2020

A little extra detail is that these and in the until clause can be used as an array (ansible >2.8.something), like so:

      until:
        - _result.json is defined
        - _result.json.status == "green" or  _result.json.status == "yellow" and single_node

and the block clause that starts on line 8 needs a extra level of identation (2 spaces)

@Zenidd
Copy link
Contributor Author

Zenidd commented Nov 9, 2020

Just replaced the until statement syntax with your suggestion @neonmei. I added parenthesis in the conditional checking the cluster status to ensure legibility. Fixed on af948df

@neonmei neonmei merged commit 75f1669 into master Nov 9, 2020
@manuasir manuasir deleted the feature-es-cluster-check-fix branch November 9, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants