Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependancy (package) (user group) #670

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Add missing dependancy (package) (user group) #670

merged 2 commits into from
Nov 25, 2021

Conversation

Tinyblargon
Copy link

@Tinyblargon Tinyblargon commented Nov 18, 2021

Added gnupg to the list of installed applications for Debian, as it is used later in the playbook. Missing gnupg makes the following part of the playbook fail.

Added an task to ensure the wazuh group exists, else the following part of the playbook will fail.

@Tinyblargon Tinyblargon changed the title Add missing package (dependancy) Add missing dependancy (package) (user group) Nov 18, 2021
@myu1d157h0u54nd myu1d157h0u54nd self-assigned this Nov 24, 2021
alberpilot
alberpilot previously approved these changes Nov 24, 2021
Copy link
Contributor

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberpilot alberpilot changed the base branch from master to 4.3 November 24, 2021 16:04
@alberpilot alberpilot dismissed their stale review November 24, 2021 16:04

The base branch was changed.

Copy link
Contributor

@myu1d157h0u54nd myu1d157h0u54nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myu1d157h0u54nd
Copy link
Contributor

Hello @
Thank you for using Wazuh and contributing to improve it. I will be taking this PR for testing and review.

In our master branch it corresponds to the development version. It is possible that I will move the destination of the merge to branch 4.3 to take it to the stable branch within the flow that we carry.

I did a test with the agent installation on Debian (buster64 / version 10). With satisfactory results.

LGTM

@alberpilot alberpilot merged commit a38c64a into wazuh:4.3 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants