Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom rules/decoders files #81

Merged
merged 1 commit into from
Nov 9, 2018
Merged

adding custom rules/decoders files #81

merged 1 commit into from
Nov 9, 2018

Conversation

cadoming
Copy link
Contributor

@cadoming cadoming commented Nov 9, 2018

This PR is inspired by the PR #62 that the user @memelet, thank you @memelet for your work, with the aim of adding extra local rules/decoders files.

To make this work we have modified the files:

  • tasks/main.yml adding new tasks ("Adding local rules" and "Adding local decoders")
  • defaults/main.yml to include the variables used in the new tasks in tasks/main.yml

In addition, we have created the example files:

  • custom_ruleset/rules/sample_custom_rules.xml
  • custom_ruleset/decoders/sample_custom_decoders.xml

Copy link
Contributor

@SitoRBJ SitoRBJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cadoming and @memelet,

Very good work. We have checked the modifications and they work perfectly.

Thank you so much for your contribution. We proceed to merge the code.

Kind regards,

Alfonso Ruiz-Bravo

@SitoRBJ SitoRBJ merged commit cf11aea into 3.7 Nov 9, 2018
@SitoRBJ SitoRBJ deleted the PR-62_add_local_rules branch November 9, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants