Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Agent Search Bar - Regex Query Interpreter #2834

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

asteriscos
Copy link
Member

Hi team, this PR fixes:

Search bar filters in Agents view.
Misreading of a regular expression caused misinterpretation o the search input value.
Closes: #2810

Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Goog catch!

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@frankeros frankeros linked an issue Jan 25, 2021 that may be closed by this pull request
@Desvelao
Copy link
Member

I tested the PR and it is working:
image

@Desvelao Desvelao self-requested a review January 26, 2021 15:55
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit aa45810 into 4.0-7.10 Jan 26, 2021
@Desvelao Desvelao deleted the bugfix/2810-filters-in-agents-preview branch January 26, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters do not work in agents preview
4 participants