Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'unselect all' option is useless #4065

Closed
mauromalara opened this issue Apr 20, 2022 · 3 comments · Fixed by #4126
Closed

The 'unselect all' option is useless #4065

mauromalara opened this issue Apr 20, 2022 · 3 comments · Fixed by #4126
Assignees
Labels
qa/report QA Team: Reporting possible bug type/enhancement Enhancement issue

Comments

@mauromalara
Copy link

Wazuh Elastic Rev Security
4.3 (rc6) 7.x 4xxx Basic, ODFE, Xpack
Browser
Firefox

Description
When the user wants to export the information of the group in PDF format 2 options are displayed; if both are unselected then the 'Generate PDF report' option is disabled. So, the 'Unselect all' option is useless.

Preconditions

  1. A group must exist

Steps to reproduce

  1. Navigate to 'Management/Groups'
  2. Select any group
  3. Select the 'Export PDF' option

Requested change
The 'Unselect all' option should be deleted because only 2 options are available and this option isn't useful for the user.

Screenshots

unselect_option_not_used.mp4
@gdiazlo
Copy link
Member

gdiazlo commented Apr 22, 2022

We should remove the select all and unselect all. Two entries are not something which needs to be automated I think.

@chantal-kelm chantal-kelm self-assigned this Apr 28, 2022
@chantal-kelm
Copy link
Member

In the following image, you can see the two selectors that should be eliminated:

Screenshot from 2022-04-29 07-59-09

In order to test this issue, click 'manage' -> 'groups', choose a group, and click the 'export PDF' button, you will see that the 'select all and deselect all' selectors no longer appear

In the following image, you can see the selectors already eliminated:

Screenshot from 2022-04-28 21-31-39

@chantal-kelm
Copy link
Member

chantal-kelm commented Apr 29, 2022

The proposed solution is that when the options are more than 3 the selectors appear (select all and deselect all)

In order to test this issue, click 'manage' -> 'groups', choose a group, and click the 'export PDF' button, you will see that the 'select all and deselect all' selectors no longer appear

In the image you can see that when the options are 3 or less, the select all and unselect all buttons are not visible.
Screenshot from 2022-04-29 15-15-01

In this image you can see that when the options are more than 3 the select all and unselect all buttons are seen
Screenshot from 2022-04-29 15-16-18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/report QA Team: Reporting possible bug type/enhancement Enhancement issue
Projects
No open projects
Status: Done
4 participants