Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

management -> groups -> agent: selectors appear when there are more t… #4126

Merged
merged 8 commits into from Apr 29, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Apr 29, 2022

In order to test this issue, click 'manage' -> 'groups', choose a group, and click the 'export PDF' button, you will see that the 'select all and deselect all' selectors no longer appear

In the image you can see that when the options are 3 or less, the select all and unselect all buttons are not visible.
Screenshot from 2022-04-29 15-15-01

In this image you can see that when the options are more than 3 the select all and unselect all buttons are seen
Screenshot from 2022-04-29 15-16-18

package.json Outdated
@@ -43,7 +43,6 @@
"angular-animate": "1.7.8",
"angular-chart.js": "1.1.1",
"angular-material": "1.1.18",
"axios": "^0.21.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies should not be removed.

Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR OK ✅
TEST OK ✅

image

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36527 )
Branches 1.61% ( 459 / 28488 )
Functions 2.98% ( 266 / 8929 )
Lines 4.08% ( 1426 / 34923 )

@matiasmoreno876 matiasmoreno876 merged commit a91e9a9 into 4.3-7.10 Apr 29, 2022
@matiasmoreno876 matiasmoreno876 deleted the 4065-TwoSelectors branch April 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'unselect all' option is useless
3 participants