New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX improvements (1) #1263
Merged
Merged
UI/UX improvements (1) #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR solves part of #1264
Reduce column size for last four columns in the policies list from
sca
, title and description should be enough big to be human readableImprove expandable box for check details under a specific policy.
Add
dynamic columns
feature for checks table under a specific policy.Do not close the editor regardless the API calls result
Do not remove/hide the rule name input box even if the user has entered the name.
Once the user clicks on "Save" we want to replace the save icon with a loading spinner inside the button until the request ends.
The multiline red errors we are showing under "Edit ..." must be relocated to a new card box in the top of the current box. Its style must be the same (white background, small border). This new box is located under the buttons and in the top of the "Edit ..." box.
Do not use a toaster for "Restart now or I'll do it later", we want to show it next to the action buttons (in-line).
Replace "Only custom" with "Custom rules" / "Custom decoders"
Replace "Group group-name will be added to agent agent-id" with "Agent agent-name will be added to group group-name"
Add delay after the
validation
and before therestarting
action itself, the restart must be triggered after 15s (setTimeout(() => restart(),15000)
??)Replace "It may take a few seconds..." with "It will take up to 15 seconds"
ID column is too much large, reduce it, please. We can even detect if it's an agents table and hardcode its width.
Regards.