Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX improvements (1) #1263

Merged
merged 15 commits into from Feb 25, 2019
Merged

UI/UX improvements (1) #1263

merged 15 commits into from Feb 25, 2019

Conversation

juankaromo
Copy link
Contributor

@juankaromo juankaromo commented Feb 21, 2019

Hi team,

This PR solves part of #1264

  • Reduce column size for last four columns in the policies list from sca, title and description should be enough big to be human readable

  • Improve expandable box for check details under a specific policy.

  • Add dynamic columns feature for checks table under a specific policy.

  • Do not close the editor regardless the API calls result

  • Do not remove/hide the rule name input box even if the user has entered the name.

  • Once the user clicks on "Save" we want to replace the save icon with a loading spinner inside the button until the request ends.

  • The multiline red errors we are showing under "Edit ..." must be relocated to a new card box in the top of the current box. Its style must be the same (white background, small border). This new box is located under the buttons and in the top of the "Edit ..." box.

  • Do not use a toaster for "Restart now or I'll do it later", we want to show it next to the action buttons (in-line).

  • Replace "Only custom" with "Custom rules" / "Custom decoders"

  • Replace "Group group-name will be added to agent agent-id" with "Agent agent-name will be added to group group-name"

  • Add delay after the validation and before the restarting action itself, the restart must be triggered after 15s (setTimeout(() => restart(),15000) ??)

  • Replace "It may take a few seconds..." with "It will take up to 15 seconds"

  • ID column is too much large, reduce it, please. We can even detect if it's an agents table and hardcode its width.

Regards.

@juankaromo juankaromo added the type/enhancement Enhancement issue label Feb 21, 2019
@juankaromo juankaromo self-assigned this Feb 21, 2019
@juankaromo juankaromo added this to Needs review in Wazuh 3.9.x - 6.6.x via automation Feb 21, 2019
@juankaromo juankaromo changed the title UI texts changes and other improvements UI improvements Feb 21, 2019
@juankaromo juankaromo changed the title UI improvements UI/UX improvements Feb 21, 2019
@jesusgn90 jesusgn90 changed the title UI/UX improvements UI/UX improvements (1) Feb 21, 2019
@jesusgn90 jesusgn90 merged commit a5245cf into 3.9-6.6 Feb 25, 2019
Wazuh 3.9.x - 6.6.x automation moved this from Needs review to Done Feb 25, 2019
@jesusgn90 jesusgn90 deleted the ui-feedback branch February 25, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants