-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0-7.9] Implement wazuh users' CRUD #2598
Conversation
public/components/security/roles/services/get-roles.service.tsx
Outdated
Show resolved
Hide resolved
public/components/security/rules/services/get-rules.service.tsx
Outdated
Show resolved
Hide resolved
public/components/security/rules/services/get-rules.service.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the files you have created as tsx
and do not use them to create React components and change the extension to ts
public/components/security/roles-mapping/components/rule-editor.tsx
Outdated
Show resolved
Hide resolved
@Desvelao thanks a lot for the feedback
The forms (create / edit user) validation was improved.
Now when the forms (create / edit user) are invalid or not have changes the apply button is disabled
The new services (roles, users, rules) and the internal users in role mapping are sorted by name now.
It's a bug in the API, already this issue was reported here wazuh/wazuh#6594. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi team! This resolves
Closes #2595