Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0-7.9] Implement wazuh users' CRUD #2598

Merged
merged 13 commits into from
Nov 16, 2020

Conversation

frankeros
Copy link
Contributor

@frankeros frankeros commented Nov 6, 2020

Hi team! This resolves

  • Replace section Security/Users implementing wazuh users' CRUD

Closes #2595

@frankeros frankeros self-assigned this Nov 6, 2020
@frankeros frankeros added this to the Sprint 119 milestone Nov 6, 2020
@frankeros frankeros marked this pull request as ready for review November 11, 2020 13:49
Copy link
Contributor

@jsanchez91 jsanchez91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the files you have created as tsx and do not use them to create React components and change the extension to ts

@Desvelao
Copy link
Member

Desvelao commented Nov 12, 2020

I found some things to review while I was testing the PR:

It could not be working as it should the validation of Password and Confirm password fields. No message is shown. Note Password has one more character than Confirm password
image

Maybe disable the Apply button when there is some error in the form?
image

This could be alphabetically sorted
image

This could is not be related to the app, but I get the next error if I try to remove the readonly role in a custom role mapping.
The role mapping contains a custom user called wazuh
image

@frankeros
Copy link
Contributor Author

frankeros commented Nov 13, 2020

@Desvelao thanks a lot for the feedback

I could not be working as it should the validation of Password and Confirm password fields. No message is shown. Note Password has one more character than Confirm password

The forms (create / edit user) validation was improved.

Maybe disable the Apply button when there is some error in the form?

Now when the forms (create / edit user) are invalid or not have changes the apply button is disabled

This could be alphabetically sorted

The new services (roles, users, rules) and the internal users in role mapping are sorted by name now.

This could is not be related to the app, but I get the next error if I try to remove the readonly role in a custom role mapping.
The role mapping contains a custom user called wazuh

It's a bug in the API, already this issue was reported here wazuh/wazuh#6594.

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jsanchez91 jsanchez91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsanchez91 jsanchez91 merged commit d8b1653 into 4.0-7.9 Nov 16, 2020
@jsanchez91 jsanchez91 deleted the feature/issue-2595-wazuh-api-users-crud branch November 16, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants