Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fixed rule id missing sample data #2618

Merged
merged 3 commits into from Nov 13, 2020
Merged

[BUGFIX] Fixed rule id missing sample data #2618

merged 3 commits into from Nov 13, 2020

Conversation

frankeros
Copy link
Contributor

Hi team! This resolves:

  • Inconsistent data in sample data alerts

Closes #2614

@frankeros frankeros changed the base branch from master to 4.0-7.9 November 12, 2020 16:06
pablomarga
pablomarga approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing it this PR seems to fixed the rule id missing error. Well done @frankeros

@pablomarga pablomarga self-requested a review November 13, 2020 09:47
jsanchez91
jsanchez91 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@jsanchez91 jsanchez91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsanchez91 jsanchez91 removed the request for review from Desvelao November 13, 2020 16:07
@jsanchez91 jsanchez91 merged commit e7e6ddb into 4.0-7.9 Nov 13, 2020
@jsanchez91 jsanchez91 deleted the bugfix/issue-2614-rule-id-missing-sample-data branch November 13, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanchez91 jsanchez91 jsanchez91 approved these changes

@pablomarga pablomarga Awaiting requested review from pablomarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent data in sample data alerts
3 participants
@frankeros @jsanchez91 @pablomarga