Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): increase the API entities reserved IDs #2647

Merged
merged 2 commits into from
Nov 20, 2020
Merged

feat(frontend): increase the API entities reserved IDs #2647

merged 2 commits into from
Nov 20, 2020

Conversation

Desvelao
Copy link
Member

Hi team, this PR resolves:

  • Created a method to check if an API entity is reserved (ID < 100)

closes #2643

@Desvelao Desvelao self-assigned this Nov 20, 2020
@Desvelao Desvelao linked an issue Nov 20, 2020 that may be closed by this pull request
Problem in the visualization of new reserved resources of the Wazuh API #2643
Closed
@Desvelao Desvelao marked this pull request as ready for review November 20, 2020 11:01
frankeros
frankeros approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jsanchez91
jsanchez91 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jsanchez91 jsanchez91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsanchez91 jsanchez91 merged commit 382618b into 4.0-7.9 Nov 20, 2020
@jsanchez91 jsanchez91 deleted the feature/2643-increase-api-entities-reserved-id branch November 20, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanchez91 jsanchez91 jsanchez91 approved these changes

@frankeros frankeros frankeros approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem in the visualization of new reserved resources of the Wazuh API
3 participants
@Desvelao @jsanchez91 @frankeros