-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/cluster delay error #2651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the requested changes and update the CHANGELOG file with the Issue.
Remember to update your branch with the last changes in the branch 4.0-7.9
this.props.onRestarted(); | ||
this.showToast('success', `${data.restarted === 'cluster' ? 'Restarting cluster, it will take up to 30 seconds.': 'Manager was restarted'}`) | ||
this.showToast('success', `${data.restarted === 'cluster' ? 'Cluster was restarted': 'Manager was restarted'}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the possible values of data.restarted
are cluster
or manager
change the string template to:
`${data.restarted} was restarted`
462a37f
to
16509ba
Compare
server/controllers/wazuh-api.js
Outdated
const del = data.delay; | ||
delete data.delay; | ||
setTimeout(() => { | ||
this.makeRequest(method, path, data, id, reply, token).then(console.log).catch(console.log); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should log here, maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi team! This PR solves the delay problem restarting the cluster when you edit a rule.
Closes #2640