Bugfix/cluster delay error #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomarga
requested review from
Desvelao and
jsanchez91
and removed request for
Desvelao
jsanchez91
suggested changes
Nov 27, 2020
| this.props.onRestarted(); | ||
| this.showToast('success', `${data.restarted === 'cluster' ? 'Restarting cluster, it will take up to 30 seconds.': 'Manager was restarted'}`) | ||
| this.showToast('success', `${data.restarted === 'cluster' ? 'Cluster was restarted': 'Manager was restarted'}`) |
There was a problem hiding this comment.
If the possible values of data.restarted are cluster or manager change the string template to:
`${data.restarted} was restarted`
pablomarga
force-pushed
the
bugfixed/ClusterDelayError
branch
from
462a37f
to
16509ba
Compare
Desvelao
reviewed
Nov 27, 2020
server/controllers/wazuh-api.js
Outdated
| const del = data.delay; | ||
| delete data.delay; | ||
| setTimeout(() => { | ||
| this.makeRequest(method, path, data, id, reply, token).then(console.log).catch(console.log); |
There was a problem hiding this comment.
I think we should log here, maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team! This PR solves the delay problem restarting the cluster when you edit a rule.
Closes #2640