Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): add the metafields when refreshing the index pattern #2681

Merged
merged 3 commits into from
Dec 18, 2020
Merged

fix(frontend): add the metafields when refreshing the index pattern #2681

merged 3 commits into from
Dec 18, 2020

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 9, 2020

Hi team,

this PR resolves:

  • Add the metafields _id, _index, _score _source, _type when refreshing index patterns. Included in the known fields too.

@Desvelao Desvelao changed the title fix(frontend): add metafields when refresh index pattern fix(frontend): add metafields when refreshing index pattern Dec 9, 2020
@Desvelao Desvelao changed the title fix(frontend): add metafields when refreshing index pattern fix(frontend): add the metafields when refreshing the index pattern Dec 9, 2020
frankeros
frankeros approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablomarga pablomarga self-requested a review December 15, 2020 12:01
pablomarga
pablomarga approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done as usual @Desvelao

@Desvelao Desvelao self-assigned this Dec 18, 2020
@Desvelao Desvelao merged commit e8a2bc2 into 4.0-7.9 Dec 18, 2020
@Desvelao Desvelao deleted the fix/metafields-refresh-index-pattern branch December 18, 2020 16:49
@frankeros frankeros mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

@frankeros frankeros frankeros approved these changes

@pablomarga pablomarga pablomarga approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Desvelao @gabiwassan @frankeros @pablomarga