Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #270

Merged
merged 2 commits into from Feb 20, 2018
Merged

Minor fixes #270

merged 2 commits into from Feb 20, 2018

Conversation

havidarou
Copy link
Member

This PR does the following:

  • Remove the unused implicitFilters service.
  • Remove visualizations loading status trace from controllers and visualization directive. Now it's only handled in the discover directive (it makes way more sense as that's the place where filters and searches are managed).

Regards.

@havidarou havidarou merged commit c810ea1 into 3.2 Feb 20, 2018
@havidarou havidarou deleted the 3.2-minor-fixes branch February 20, 2018 12:54
JuanjiJG added a commit that referenced this pull request Feb 20, 2018
@JuanjiJG
Updated CHANGELOG.md with #270
b4c215b
JuanjiJG added a commit that referenced this pull request Feb 22, 2018
@JuanjiJG
Updated CHANGELOG.md with #270
1ac937a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@havidarou