Feature/2702/wui rules #2708
Merged
Feature/2702/wui rules #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankeros
suggested changes
Dec 24, 2020
| return WzAPIUtils.isReservedID(item) && <EuiBadge color="primary">Reserved</EuiBadge>; | ||
| render (item, obj){ | ||
| if(WzAPIUtils.isReservedID(item)){ | ||
| if( (obj.name == "wui_elastic_admin" || obj.name == "wui_opendistro_admin")){ |
There was a problem hiding this comment.
always when it is possible, try to compare with numbers instead of strings, the id should be the field to compare
and use constants, to avoid avoid keeping values in different places in code
There was a problem hiding this comment.
Okay, so I proceed to change it and i will keep in mind for future occasions. Thank you!
|
|
gabiwassan
reviewed
Dec 28, 2020
| return WzAPIUtils.isReservedID(item) && <EuiBadge color="primary">Reserved</EuiBadge>; | ||
| render (item, obj){ | ||
| if(WzAPIUtils.isReservedID(item)){ | ||
| if( (obj.id == 1 || obj.id == 2)){ |
There was a problem hiding this comment.
it is recommended to use ===
There was a problem hiding this comment.
Okay, it is changed and I will keep it in mind for future occasions. Thank you.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, we're resolving issue #2702 with that following steps:
Closes Show the wui_ rules belong to wazuh-wui API user #2702