Fixed error due to new use of path in the export of lists #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Dec 30, 2020
| name: 'path', | ||
| value: `${path}/${name}` | ||
| name: 'relative_dirname', | ||
| value: `${path}` |
There was a problem hiding this comment.
If you don't need to interpolate any variable into the string, you can set the variable as value object key.
There was a problem hiding this comment.
Well, I have applied your advice. Thank you!
frankeros
deleted the
feature/2692-Error-500-on-Export-formatted-CDB-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, we resolve the issue #2692 with this steps:
pathtorelative_dirnameandfilename(which is the new way to use it) and instead of concatenating name, we pass another filter passing this name to filename