Feature/add warning when configuring new role mapping #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankeros
suggested changes
Feb 1, 2021
public/components/security/roles-mapping/components/rule-editor.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Feb 2, 2021
|
I tested the PR and I found the callout is showing in all Do we want to show this message in all tabs of the Security section or it should only appear in |
|
I tested it, works well but when you have the setting |
frankeros
reviewed
Feb 4, 2021
public/components/security/main.tsx
Outdated
| @@ -103,10 +145,13 @@ export const WzSecurity = compose( | |||
| <Policies></Policies> | |||
| } | |||
| {selectedTabId === 'roleMapping' && | |||
| <RolesMapping></RolesMapping> | |||
| <> | |||
| {allowRunAs !== API_USER_STATUS_RUN_AS.ENABLED && isNotRunAs()} | |||
There was a problem hiding this comment.
you could add another state to wait for the request to complete, maybe
{allowRunAs !== API_USER_STATUS_RUN_AS.ENABLED && !allowRunAsIsLoading && isNotRunAs()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team this PR adds a toast warning the user when configuring role mapping if run_as is set to false.
Closes #2851