Increase the default max buckets #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Feb 4, 2021
| } | ||
|
|
||
| async function updateMaxBucketsSetting(isModified: boolean) { | ||
| console.log("ENTRA AQUI 3") |
Desvelao
reviewed
Feb 4, 2021
| return !isModified && await GenericRequest.request( | ||
| 'POST', | ||
| '/api/kibana/settings', | ||
| { "changes": { "timelion:max_buckets": JSON.stringify(WAZUH_MAX_BUCKETS_DEFAULT) } } |
There was a problem hiding this comment.
The WAZUH_MAX_BUCKETS_DEFAULT is a number, you don't need to do:
JSON.stringify(WAZUH_MAX_BUCKETS_DEFAULT)
Simply, you could do:
{ "changes": { "timelion:max_buckets": WAZUH_MAX_BUCKETS_DEFAULT } }
Desvelao
reviewed
Feb 4, 2021
| } | ||
|
|
||
| const maxBuckets = settings["timelion:max_buckets"].userValue; | ||
| const maxBucketsObject = JSON.parse(maxBuckets); |
There was a problem hiding this comment.
Why use JSON.parse here? It should be a number.
frankeros
suggested changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team! This PR solved the problem that was caused when entering Statistics and executing a query greater than 1 day.
Closes #2765