Unchecked the agents when you click outside #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiwassan
reviewed
Feb 2, 2021
| @@ -498,6 +498,9 @@ export class MultipleAgentSelector extends Component { | |||
| size='15' | |||
| multiple | |||
| onChange={(e) => { | |||
| document.getElementById("wzMultipleSelectorRight").childNodes.forEach(option => { | |||
There was a problem hiding this comment.
Can you put all of this code in a new method and maybe you can reuse the method with param wzMultipleSelectorRight/wzMultipleSelectorLeft
Desvelao
reviewed
Feb 3, 2021
Comment on lines
347
to
359
| unselectLeftRight(element) { | ||
| switch (element) { | ||
| case 'left': | ||
| return document.getElementById("wzMultipleSelectorLeft").childNodes.forEach(option => { | ||
| option.selected = false | ||
| }) | ||
| case 'right': | ||
| return document.getElementById("wzMultipleSelectorRight").childNodes.forEach(option => { | ||
| option.selected = false | ||
| }) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Why not use the container id as the param. You could simplify to:
unselectElementsOfSelectByID(containerID) {
document.getElementById(containerID).selectedOptions.forEach(option => {
option.selected = false
});
}
A more descriptive name for the function will better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, this PR solved the problem that agents were not unchecked when switching from Available agents to Current agents in
Management > Groups.Closes #2889