Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed access to forbidden agents #2918

Merged
merged 3 commits into from Feb 4, 2021
Merged

Fixed access to forbidden agents #2918

merged 3 commits into from Feb 4, 2021

Conversation

pablomarga
Copy link
Contributor

Hi team, this PR solves the problem related to the access to forbidden agents information when exporting agents list.
Closes #2900

@pablomarga pablomarga requested a review from a team February 3, 2021 11:02
@pablomarga pablomarga self-assigned this Feb 3, 2021
@Desvelao
Copy link
Member

Desvelao commented Feb 4, 2021

I tested the PR with an user with permission only to read one agent ant the Export formatted in Agents section generates a .csv with that agent. It is working.

Desvelao
Desvelao approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit a4c4643 into 4.1-7.10 Feb 4, 2021
@frankeros frankeros deleted the fix/access-forbidden-agents branch February 4, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@pablomarga pablomarga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pablomarga @Desvelao @frankeros