Fixed bug in the filters of flyouts #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiwassan
approved these changes
Feb 4, 2021
Desvelao
reviewed
Feb 4, 2021
| @@ -108,7 +108,7 @@ export const Discover = compose( | |||
| constructor(props) { | |||
| super(props); | |||
| this.KibanaServices = getDataPlugin(); | |||
| this.filterManager = props.shareFilterManager ? this.KibanaServices.query.filterManager : new FilterManager(getUiSettings); | |||
| this.filterManager = props.shareFilterManager ? this.KibanaServices.query.filterManager : this.KibanaServices.query.filterManager; | |||
There was a problem hiding this comment.
Here, this.filterManager always has the same value, don't?
Why not, simplify to:
this.filterManager = this.Kibanaservices.query.filerManager
|
I tested the PR and it is working! |
frankeros
reviewed
Feb 4, 2021
…n-Regulatory-Compliance-and-Mitre
gabiwassan
approved these changes
Feb 4, 2021
…n-Regulatory-Compliance-and-Mitre
frankeros
deleted the
Features/Fixed-bug-filters-in-floyouts-in-Regulatory-Compliance-and-Mitre
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, we have resolved a bug that did not allow us to use filters in both Miter flyouts and Regulatory Compliance tables.
Closes. #2895.