Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ossec to Wazuh #3046

Merged
merged 12 commits into from Apr 6, 2021
Merged

Rename Ossec to Wazuh #3046

merged 12 commits into from Apr 6, 2021

Conversation

CPAlejandro
Copy link
Contributor

@CPAlejandro CPAlejandro commented Mar 3, 2021

Hi team, we resolve:

@@ -13,7 +13,7 @@
// Mitre
export const arrayMitreRules = [
{
filename: '0015-ossec_rules.xml',
filename: '0015-wazuh_rules.xml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file 0015-ossec_rules.xml exists in my environment with 4.2.0 building from sources (branch master) some days ago.
image

},
{
filename: '0015-ossec_rules.xml',
filename: '0015-wazuh_rules.xml',
Copy link
Member

@Desvelao Desvelao Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file 0015-ossec_rules.xml exists in my environment. Check the comment above.

filename: '0015-ossec_rules.xml',
filename: '0015-wazuh_rules.xml',
Copy link
Member

@Desvelao Desvelao Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file 0015-ossec_rules.xml exists in my environment. Check the comment above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed and you are absolutely right, I change it, thanks!

@Desvelao
Copy link
Member

Desvelao commented Mar 8, 2021

The change should be added to CHANGELOG.md file.

@@ -1,6 +1,12 @@
# Change Log

All notable changes to the Wazuh app project will be documented in this file.
## Wazuh v4.2.0 - Kibana 7.10.0 , 7.10.2 - Revision 4201

### Fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be Changed instead of Fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have change it. Thanks you!

groups: ['ossec'],
description: 'Ossec agent disconnected.',
groups: ['wazuh'],
description: 'Wazuh agent disconnected.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the rule description change to use Wazuh instead of Ossec? Could we check with the team?

@Desvelao
Copy link
Member

Desvelao commented Apr 5, 2021

The target branch should be changed to 4.2-7.10.

@Desvelao Desvelao changed the base branch from 4.1-7.10 to 4.2-7.10 April 5, 2021 16:05
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes related to this issue #3037

@frankeros frankeros merged commit d97dfd9 into 4.2-7.10 Apr 6, 2021
@frankeros frankeros deleted the feature/rename-ossec-to-wazuh branch April 6, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants