Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividers and tooltips cleanup #305

Merged
merged 11 commits into from
Mar 9, 2018
Merged

Dividers and tooltips cleanup #305

merged 11 commits into from
Mar 9, 2018

Conversation

JuanjiJG
Copy link
Contributor

@JuanjiJG JuanjiJG commented Mar 9, 2018

Hello all,

This Pull Request adds even more adjustments and cleans up CSS in the app. The included changes are:

  • Removed an unused CSS class and reviewed another one to fix a tooltip problem on Manager/Configuration.
    • This fix adds a class to almost every md-divider component throughout the app.
  • Removed almost every md-tooltip component and replaced with the same system as Kibana's.
    • There's still Angular tooltips on Agents General until we can find a replacement for showing scans correctly.
  • Some flex adjustments in Agents Preview.
  • Removed bottom border from Kibana search bar.
  • Removed unused images from the img folder.
  • Added line height to PCI Description tabs.
  • Added missing spaces in Settings.

I hope this to be useful for the project.

Best regards,
Juanjo

@JuanjiJG JuanjiJG requested a review from havidarou March 9, 2018 09:27
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 80f8ec2 into 3.2 Mar 9, 2018
havidarou pushed a commit that referenced this pull request Mar 9, 2018
havidarou pushed a commit that referenced this pull request Mar 9, 2018
@havidarou havidarou deleted the 3.2-dev-clean-tooltips branch March 9, 2018 11:21
@JuanjiJG JuanjiJG added bugfix and removed type/bug Bug issue enhancement labels Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants