Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statistics visualizations when a node is selected #3110

Merged
merged 10 commits into from Apr 9, 2021

Conversation

pablomarga
Copy link
Contributor

Hi team this PR solves:

  • The graph for Events processed and Events dropped is showing data of all nodes.

Closes #3068

How to Test:

To test this PR you need a worker node, then you should go to Management > Statistics > Analysis Engine. There you have to select a node and the graphs must show only data about this node.

Captura de pantalla 2021-03-29 a las 13 50 06

@pablomarga pablomarga requested a review from a team March 29, 2021 11:51
@pablomarga pablomarga self-assigned this Mar 29, 2021
@pablomarga pablomarga changed the base branch from 4.1-7.10 to 4.2-7.10 April 6, 2021 07:44
@Desvelao
Copy link
Member

Desvelao commented Apr 6, 2021

Testing ❌

  • When selected one manager node, the line display the total instead the values related to the node.
    All
    image
    master-node
    image
    worker-node
    image

The same graph is displayed for master-node and worker-node when using the node selector. When all is selected, the graphs for the nodes look like different.

@Desvelao Desvelao linked an issue Apr 6, 2021 that may be closed by this pull request
@Desvelao
Copy link
Member

Desvelao commented Apr 7, 2021

Test ✅
✅ Visualization when selecting a manager node is working.
all
image
manager-node
image
worker-node
image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 1d76b16 into 4.2-7.10 Apr 9, 2021
@frankeros frankeros deleted the fix/statistics-visualizations-node branch April 9, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The graph for Events processed is showing data of all nodes
4 participants