Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flyout date #3114

Merged
merged 9 commits into from Apr 5, 2021
Merged

Fix flyout date #3114

merged 9 commits into from Apr 5, 2021

Conversation

pablomarga
Copy link
Contributor

@pablomarga pablomarga commented Apr 5, 2021

Hi team this PR solves:

  • Flyout date filter also changes main date filter

How to test

To test this PR you should go to MITRE section an then click on a technique. When the flyout is displayed you have to change the time filter and it should change but the main time filter shall remain as before.

Grabacion.de.pantalla.2021-04-05.a.las.13.10.35.mov

Closes #3040

@pablomarga pablomarga requested a review from a team April 5, 2021 11:12
@pablomarga pablomarga self-assigned this Apr 5, 2021
@pablomarga pablomarga changed the base branch from 4.1-7.10 to 4.2-7.10 April 5, 2021 11:32
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. LGTM!

@frankeros frankeros merged commit 5454a8b into 4.2-7.10 Apr 5, 2021
@frankeros frankeros deleted the fix/flyout-date branch April 5, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants