Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix default index patterns [Health-check] #3223

Merged
merged 13 commits into from May 7, 2021
Merged

Bugfix default index patterns [Health-check] #3223

merged 13 commits into from May 7, 2021

Conversation

gabiwassan
Copy link
Contributor

Hi team,
This PR fixed the problem when Index-pattern is not present on health-check.

Close: #3169

@gabiwassan gabiwassan marked this pull request as draft May 4, 2021 17:33
@gabiwassan gabiwassan requested review from frankeros and asteriscos and removed request for asteriscos and frankeros May 4, 2021 17:33
frankeros
frankeros suggested changes May 4, 2021
View reviewed changes
public/react-services/saved-objects.js Outdated Show resolved Hide resolved
public/react-services/pattern-handler.js Outdated Show resolved Hide resolved
public/react-services/saved-objects.js Outdated Show resolved Hide resolved
public/react-services/saved-objects.js Outdated Show resolved Hide resolved
public/react-services/saved-objects.js Outdated Show resolved Hide resolved
@gabiwassan gabiwassan requested a review from frankeros May 4, 2021 19:54
@gabiwassan gabiwassan marked this pull request as ready for review May 4, 2021 21:03
@gabiwassan gabiwassan self-assigned this May 5, 2021
@gabiwassan gabiwassan changed the title Bugfix/default index patterns Bugfix default index patterns [Health-check] May 5, 2021
@gabiwassan gabiwassan mentioned this pull request May 5, 2021
Closed
@frankeros frankeros self-requested a review May 6, 2021 19:50
frankeros
frankeros approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eze9252 eze9252 self-requested a review May 6, 2021 19:50
CPAlejandro
CPAlejandro approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, upgrading 3.13.2 to 4.1.5 and don't see any errors.
Nice job!

@frankeros frankeros merged commit ee3dacc into 4.1-7.10 May 7, 2021
@frankeros frankeros deleted the bugfix/default-index-patterns branch May 7, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@eze9252 eze9252 eze9252 left review comments

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@frankeros frankeros frankeros approved these changes

@asteriscos asteriscos Awaiting requested review from asteriscos

Assignees

@gabiwassan gabiwassan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gabiwassan @CPAlejandro @frankeros @Desvelao @eze9252