Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule-test and Decoder-test flyouts click outside detector #3412

Merged
merged 12 commits into from Jul 19, 2021
Merged

Rule-test and Decoder-test flyouts click outside detector #3412

merged 12 commits into from Jul 19, 2021

Conversation

asteriscos
Copy link
Member

Hi team,

this fixes the flyout closing when dragging and releasing mouse event outside the Rule-test and Decoder-test flyout.

Closes #3298

Peek 2021-06-29 18-32

@asteriscos asteriscos self-assigned this Jun 29, 2021
@asteriscos asteriscos requested a review from a team June 30, 2021 09:27
@Desvelao Desvelao added the type/enhancement Enhancement issue label Jun 30, 2021
Desvelao
Desvelao approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✅
Testing ✅

Good job!!

question: Should we implement this logic to the rest of the flyouts? It avoids closing the flyout when clicking, drag and release outside of the flyout.

pablomarga
pablomarga approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing: ✔️
CR: ✔️

@asteriscos
Copy link
Member Author

review:
Code review
Testing

Good job!!

question: Should we implement this logic to the rest of the flyouts? It avoids closing the flyout when clicking, drag and release outside of the flyout.

Thanks for the suggestion. I applied the same feature to all other flyouts.

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.12% ( 1109 / 35565 )
Branches 1.16% ( 324 / 27933 )
Functions 2.02% ( 174 / 8632 )
Lines 3.15% ( 1071 / 33983 )

@MauGaP MauGaP merged commit f247d2a into 4.3-7.10 Jul 19, 2021
@MauGaP MauGaP deleted the fix/ruletest-and-decodertest-flyouts-click-outside-3298 branch July 19, 2021 13:33
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@pablomarga pablomarga pablomarga approved these changes

Assignees

@asteriscos asteriscos

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asteriscos @Desvelao @pablomarga @MauGaP