Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Index pattern selector doesn't display the ignored index patterns #3458

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jul 9, 2021

Description

This PR fixes the index patterns displayed on the index pattern selector.

Changes

  • Fix the ignored index patterns on the index pattern selector.
  • Removed wrong behavior when selecting an input on Configuration > Setting and appears as an unsaved setting.

Test

  1. Create or be sure you have at least 2 index patterns and the index pattern selector is enabled.
  2. Go to Configuration > Settings
  3. Edit the ip.ignore app setting adding some of the index patterns you have and save the configuration.
  4. The ignored index patterns should disappear from the selector. Take into account the index pattern selector could disappear if you only have a valid index pattern.

Closes #3338

…index patterns defined in `ip.ignore` app setting
… a input with array type on Settings > Configuration
@Desvelao Desvelao added the type/bug Bug issue label Jul 9, 2021
@Desvelao Desvelao self-assigned this Jul 9, 2021
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing: LGTM ✔️

@Desvelao Desvelao changed the title [FIX] Index pattern selector doesn't displays the ignored index patterns [FIX] Index pattern selector doesn't display the ignored index patterns Jul 9, 2021
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Testing: ✔️

@frankeros frankeros merged commit c929fae into 4.3-7.10 Jul 21, 2021
@frankeros frankeros deleted the fix/3338-index-pattern-selector-not-ignore-index-patterns branch July 21, 2021 12:41
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.81% ( 1357 / 35659 )
Branches 1.47% ( 413 / 28108 )
Functions 2.61% ( 225 / 8615 )
Lines 3.85% ( 1312 / 34090 )

gabiwassan pushed a commit that referenced this pull request Jul 30, 2021
…ns (#3458)

* fix(frontend): Fix index pattern selector on menu doesn't ignore the index patterns defined in `ip.ignore` app setting

* fix(frontend): Fix problem that set as unsaved changes when selecting a input with array type on Settings > Configuration
gabiwassan pushed a commit that referenced this pull request Aug 5, 2021
…ns (#3458)

* fix(frontend): Fix index pattern selector on menu doesn't ignore the index patterns defined in `ip.ignore` app setting

* fix(frontend): Fix problem that set as unsaved changes when selecting a input with array type on Settings > Configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants