Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in save before exit prompt in configuration edit #3460

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Fix error in save before exit prompt in configuration edit #3460

merged 4 commits into from
Jul 19, 2021

Conversation

mpRegalado
Copy link
Member

Closes #3341

This PR fixes an issue where, if you tried to exit a configuration edit menu after saving, it would still ask you to save.

Testing:

  • Go to Management/Configuration and click on Edit Configuration
  • Make any changes
  • Check that attempting to exit without saving shows the prompt
  • Save
  • Check that attempting to exit does no longer show the prompt

@mpRegalado mpRegalado requested a review from a team July 12, 2021 09:27
@mpRegalado mpRegalado self-assigned this Jul 12, 2021
@mpRegalado mpRegalado linked an issue Jul 12, 2021 that may be closed by this pull request
Configuration editors warn you about unsaved changes even right after saving #3341
Closed
asteriscos
asteriscos approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@sortiz1191 sortiz1191 self-requested a review July 13, 2021 07:22
sortiz1191
sortiz1191 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@sortiz1191 sortiz1191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.12% ( 1109 / 35572 )
Branches 1.16% ( 324 / 27949 )
Functions 2.01% ( 174 / 8642 )
Lines 3.15% ( 1071 / 33998 )

@frankeros frankeros merged commit 4c092da into 4.3-7.10 Jul 19, 2021
@frankeros frankeros deleted the fix/3341_configuration-save branch July 19, 2021 18:32
Machi3mfl pushed a commit that referenced this pull request Jul 19, 2021
@mpRegalado @Machi3mfl
Fix error in save before exit prompt in configuration edit (#3460)
0b47904 
* Changed the hasChanges state to false after the file is saved succesfully
gabiwassan pushed a commit that referenced this pull request Aug 5, 2021
@mpRegalado @gabiwassan
Fix error in save before exit prompt in configuration edit (#3460)
1a4fd94 
* Changed the hasChanges state to false after the file is saved succesfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@sortiz1191 sortiz1191 sortiz1191 approved these changes

Assignees

@mpRegalado mpRegalado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration editors warn you about unsaved changes even right after saving
4 participants
@mpRegalado @asteriscos @sortiz1191 @frankeros