Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor try-catch strategy on controllers, directives and factories #3474

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

gabiwassan
Copy link
Contributor

Hi team,
This PR implements a new strategy to catch and store/show errors in the controllers, directives, and factories front-end side.

Close: #3473

@gabiwassan gabiwassan self-assigned this Jul 13, 2021
@gabiwassan gabiwassan requested a review from a team July 13, 2021 19:40
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.01% ( 1071 / 35585 )
Branches 1.12% ( 314 / 27961 )
Functions 1.93% ( 167 / 8642 )
Lines 3.04% ( 1034 / 34012 )

Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MauGaP MauGaP self-assigned this Jul 16, 2021
@frankeros frankeros merged commit 46b9107 into 4.3-7.10 Jul 19, 2021
@frankeros frankeros deleted the feat/try-catch-controllers branch July 19, 2021 18:38
Machi3mfl pushed a commit that referenced this pull request Jul 19, 2021
gabiwassan added a commit that referenced this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants