Added Sample Data Component #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpRegalado
requested review from
gabiwassan,
MauGaP,
pablomarga,
matiasmoreno876 and
a team
2 tasks
gabiwassan
suggested changes
Jul 14, 2021
| title: error.name || error, | ||
| }, | ||
| }; | ||
| getErrorOrchestrator.mockImplementation(() => { |
pablomarga
suggested changes
Jul 15, 2021
Desvelao
reviewed
Jul 19, 2021
Comment on lines
22
to
42
| const usesSampleData = async () => { | ||
| try { | ||
| const result = (await WzRequest.genericReq('GET', '/elastic/samplealerts', {})).data | ||
| .sampleAlertsInstalled; | ||
| setIsSampleData(result); | ||
| } catch (error) { | ||
| const options = { | ||
| context: `${SampleData.name}.usesSampleData`, | ||
| level: UI_LOGGER_LEVELS.ERROR, | ||
| severity: UI_ERROR_SEVERITIES.UI, | ||
| error: { | ||
| error: error, | ||
| message: error.message || error, | ||
| title: error.name || error, | ||
| }, | ||
| }; | ||
| getErrorOrchestrator().handleError(options); | ||
| } | ||
| }; | ||
| useEffect(() => { | ||
| usesSampleData(); |
There was a problem hiding this comment.
nitpick: I would avoid the prefix use for a function, this prefix is usually used for hooks.
You could move the usesSampleData to the useEffect. You could use the async/await with a Self Invoking Function as:
useEffect(() => {
(async(){
// logic
})()
},[dependencies])
There was a problem hiding this comment.
Applied in the latest commit
Applied Prettier to wz-visualize
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3423
Created a component to check for sample data and display a message if it does.
This component also replaces the implementation in
WzVisualizeTo test: