Fixed flickering on Settings tab #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusgn90
reviewed
Apr 3, 2018
| @@ -15,7 +15,7 @@ | |||
| <div layout="column" layout-align="start stretch"> | |||
|
|
|||
| <!-- First-time welcome card --> | |||
| <md-card class="wz-md-card" layout-padding layout-align="start stretch" ng-if="submenuNavItem == 'api' && apiEntries.length == 0"> | |||
| <md-card class="wz-md-card" layout-padding layout-align="start stretch" ng-if="submenuNavItem == 'api' && apiEntriesLoaded && apiEntries.length == 0"> | |||
There was a problem hiding this comment.
@JuanjiJG we could use load variable who is already defined, replace && apiEntriesLoaded by && !load.
Since we can use it, you don't need any change con settings.js file, so fix it please. You should try it before any change because I didn't try it, but it should work, thanks.
There was a problem hiding this comment.
You're right, colleague. Now it's fixed, and the new variable was removed from the code. Now there are only CRLF fixes on the settings.js file. Thanks for your valuable feedback, it's really appreciated.
Regards,
Juanjo
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team!
This pull request fixes a weird flickering on the Settings tab, due to a situation where the template was loaded before knowing if there were API entries loaded, and after that, hiding again a card.
Best regards,
Juanjo