Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added try-catch stratategy in common/tables #3480

Merged
merged 7 commits into from Jul 20, 2021
Merged

Added try-catch stratategy in common/tables #3480

merged 7 commits into from Jul 20, 2021

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jul 14, 2021 •
edited

Hi team,
This PR implement our new error handling strategy in common/table

Close #3479

@Machi3mfl Machi3mfl requested a review from a team July 14, 2021 15:59
@Machi3mfl Machi3mfl self-assigned this Jul 14, 2021
@Machi3mfl Machi3mfl changed the title Implement try catch common/tables Added try-catch stratategy in common/tables Jul 14, 2021
gabiwassan
gabiwassan approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

mpRegalado
mpRegalado approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

pablomarga
pablomarga approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.59% ( 1278 / 35600 )
Branches 1.43% ( 401 / 27969 )
Functions 2.47% ( 213 / 8632 )
Lines 3.62% ( 1232 / 34018 )

@gabiwassan gabiwassan merged commit d367ec4 into 4.3-7.10 Jul 20, 2021
@gabiwassan gabiwassan deleted the feature/3479-implement-try-catch-common-tables branch July 20, 2021 16:57
gabiwassan added a commit that referenced this pull request Jul 30, 2021
@Machi3mfl @gabiwassan
Added try-catch stratategy in common/tables (#3480)
8bed94a 
* Implemented error-handling

* Updated CHANGELOG

* Added test files and snapshots

* doc(changelog): Update

* doc(changelog): Update

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
@Machi3mfl @gabiwassan
Added try-catch stratategy in common/tables (#3480)
6a87cc6 
* Implemented error-handling

* Updated CHANGELOG

* Added test files and snapshots

* doc(changelog): Update

* doc(changelog): Update

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

@pablomarga pablomarga pablomarga approved these changes

@mpRegalado mpRegalado mpRegalado approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
error-handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Machi3mfl @gabiwassan @pablomarga @mpRegalado