Fix/3489 query config refactor #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eze9252
suggested changes
Jul 19, 2021
| @@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
| import { withErrorBoundary } from '../../common/hocs'; | |||
| import { ModuleStats } from './module-stats'; | |||
| import { WzRequest } from '../../../react-services/wz-request'; | |||
| import { queryConfig } from '../../../services/query-config'; | |||
| //import { queryConfig } from '../../../services/query-config'; | |||
| @@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
| import { withErrorBoundary } from '../../common/hocs'; | |||
| import { ModuleStats } from './module-stats'; | |||
| import { WzRequest } from '../../../react-services/wz-request'; | |||
| import { queryConfig } from '../../../services/query-config'; | |||
| //import { queryConfig } from '../../../services/query-config'; | |||
| import { queryConfig } from '../../../react-services/query-config'; | |||
| import { getCurrentConfig } from '../../../controllers/management/components/management/configuration/utils/wz-fetch'; | |||
| // import { getCurrentConfig } from '../../../react-services'; | |||
asteriscos
reviewed
Jul 19, 2021
| @@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
| import { withErrorBoundary } from '../../common/hocs'; | |||
| import { ModuleStats } from './module-stats'; | |||
| import { WzRequest } from '../../../react-services/wz-request'; | |||
| import { queryConfig } from '../../../services/query-config'; | |||
| //import { queryConfig } from '../../../services/query-config'; | |||
There was a problem hiding this comment.
Could you please remove the comments to improve code readability?
asteriscos
approved these changes
Jul 19, 2021
asteriscos
merged commit ac11be0
into
feature/create-modular-view-office365-github-3422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
In this PR refactor query Config from Angular to React
To prove it,
We enter the new Office 365 section, click on the Panel tab and click on the i at the top left, which will display the panel. It should not give us any error in console.
Close: #3489