Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality to change app logos #3503

Merged
merged 9 commits into from Aug 18, 2021
Merged

Conversation

matiasmoreno876
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 commented Jul 27, 2021

Hi Team,
In this PR I add the functionality to change app logos.
Issue #3491

Steps to reproduce

  1. Go to Settings/Configuration

  2. Search the section Logo Customization
    image

  3. Define the name to the app logo, logo sidebar and health check.

  4. You have to add the new logos in the /usr/share/kibana/plugins/wazuh/public/assets path inside the Kibana container
    image
    example: icon_blue_2.svg and logotype-2.svg

  5. Change the name and save
    image

image

image
image
image

@matiasmoreno876 matiasmoreno876 self-assigned this Jul 27, 2021
@matiasmoreno876 matiasmoreno876 marked this pull request as draft July 27, 2021 19:42
@matiasmoreno876 matiasmoreno876 linked an issue Jul 29, 2021 that may be closed by this pull request
@matiasmoreno876 matiasmoreno876 marked this pull request as ready for review July 29, 2021 14:50
public/plugin.ts Outdated Show resolved Hide resolved
'customization.logo.app':'Define the name of the app logo saved in the path /plugins/wazuh/assets/',
'customization.logo.sidebar':'Define the name of the sidebar logo saved in the path /plugins/wazuh/assets/',
'customization.logo.healthcheck':'Define the name of the health-check logo saved in the path /plugins/wazuh/assets/',
'customization.logo.reports':'Define the name of the reports logo (.png) saved in the path /plugins/wazuh/assets/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't it be any type of image (png,svg,jpg,etc)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, if the .png format is not used, it breaks when generating the report.

Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@juliannediaz12
Copy link

Hi! A few weeks ago I updated my test environment and got 4.2.2 and it worked. And just today upgraded our prod manager from 4.2.1 to 4.2.4(recent) to change the logo and the option to change the logo was not there anymore. So I tried to edit the config file instead but my added variables did not take effect. I already restarted both kibana and wazuh. Was the logo customization removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the capability of customize the logo of the app
5 participants