Enhancement/3512 refactor use filter manager #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an object Switched useState by useMemo in use-filter-manager
Removed subscription handling from useEsSearch
asteriscos
merged commit a5dbe3e
into
feature/create-modular-view-office365-github-3422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #3513 but fixing a critical bug that was reverted.
The filter manager now handles it's own subscriptions and changes it's own state when filters update, returning an array of filters used globally.
This PR also refactors files that already consumed useFilterManager so they use the property filterManager of the return object
closes #3512