Integrating dynamic filters #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Aug 4, 2021
public/components/overview/github-panel/config/search-bar-config.ts
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Aug 4, 2021
| @@ -46,6 +46,7 @@ All notable changes to the Wazuh app project will be documented in this file. | |||
| - Created a separate component to check for sample data [#3475](https://github.com/wazuh/wazuh-kibana-app/pull/3475) | |||
| - Added a new hook for getting value suggestions [#3506](https://github.com/wazuh/wazuh-kibana-app/pull/3506) | |||
| - Added base Module Panel view with Office365 setup [3518](https://github.com/wazuh/wazuh-kibana-app/pull/3518) | |||
| - Added dinamic simple filters and adding simple GitHub filters fields [3531](https://github.com/wazuh/wazuh-kibana-app/pull/3531) | |||
There was a problem hiding this comment.
thought: I am not sure if we want to add this to the changelog.
…`data.github.repo` field
Desvelao
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
In this PR we integrate the dynamic filters and add the filter fields from the GitHub module.
To test it:
We will go to the Github tab, try to enter the tables, and see if the filters are applied correctly when entering the Drilldown tables and if when applying filters both in Github and in the Drilldown tables, the simple filters are modified as well.
Closes #3510