Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module] [Office365] [Panel] Add the view for the module configuration #3541

Merged
merged 5 commits into from
Aug 10, 2021
Merged

[Module] [Office365] [Panel] Add the view for the module configuration #3541

merged 5 commits into from
Aug 10, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Aug 5, 2021 •
edited
Loading

Description

This PR adds the module configuration to the Panel tab of the Office 365 module.

Features:

  • Created reusable component to display the module configuration
  • Adapted the component to the Office 365 module use case

Tests

  • For a cluster with at least 2 managers, configure the Office 365 module with different settings for each node

    • Check the module configuration is displayed for each node. An accordion should appear

  • For a cluster with at least 2 managers, configure the Office 365 module for only one manager

    • Check the module configuration is displayed for the configurated node

  • For a cluster with at least 2 managers, without Office 365 configurations

    • Should display a message with the configuration is unavailable

  • For an environment in manager mode configure the Office 365 module for the manager

    • Check the module configuration is displayed for the manager

  • For an environment in manager mode without Office 365 configuration

    • Should display a message with the configuration is unavailable

  • On the UI, pin an agent.

    • Should display a message with the configuration is unavailable

  • When there is some error, should display it using a EuiCallOut.

Closes #3539

@Desvelao
feat(module_office365): Add the module module configuration view to t…
f35ba9e 
…he `Panel` tab

  - Created reusable component to display the module configuration
  - Adapt to the Office 365 use case
@Desvelao
fix(frontend): Fix useAsyncAction which doesn't reset the data an…
8f26fda 
…d `error` states when rerun the action after the first time
@Desvelao Desvelao added the type/enhancement Enhancement issue label Aug 5, 2021
@Desvelao Desvelao requested a review from a team August 5, 2021 13:09
@Desvelao Desvelao self-assigned this Aug 5, 2021
@Desvelao Desvelao linked an issue Aug 5, 2021 that may be closed by this pull request
[Module] [Office365] [Panel] Add module configuration to the module information #3539
Closed
@sortiz1191 sortiz1191 self-requested a review August 6, 2021 07:20
@Desvelao
fix(frontend): Moved the styles for the PanelModuleConfiguration co…
22cc957 
…mponent

  - Renamed the component file
  - Adapted the imports
  - Removed `office-stats.scss` file and its import
@Desvelao
Copy link
Member Author

Desvelao commented Aug 6, 2021 •
edited
Loading

Changes

  • Moved the styles for the PanelModuleConfiguration component
  • Renamed the component file
  • Adapted the imports
  • Removed office-stats.scss file and its imports

@sortiz1191 sortiz1191 removed their request for review August 6, 2021 07:53
@Desvelao
fix(frontend): Add types to office-stats.tsx
1451493
@Desvelao
fix(frontend): Apply the request changes for the PR
dc0bc2c 
  - Removed empty line at the beginning of the file
  - Replaced as compare variable against undefined
CPAlejandro
CPAlejandro approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

@sortiz1191 sortiz1191 self-requested a review August 9, 2021 13:11
@Machi3mfl Machi3mfl self-requested a review August 9, 2021 16:45
Machi3mfl
Machi3mfl approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR y Testing ✅

Screen Shot 2021-08-09 at 13 40 59

Screen Shot 2021-08-09 at 13 44 12

@Desvelao Desvelao merged commit 1f01f71 into feature/Office365 Aug 10, 2021
@Desvelao Desvelao deleted the feat/3539-office365-panel-module-configuration branch August 10, 2021 06:13
@frankeros frankeros mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@sortiz1191 sortiz1191 Awaiting requested review from sortiz1191

Assignees

@Desvelao Desvelao

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Module] [Office365] [Panel] Add module configuration to the module information
3 participants
@Desvelao @Machi3mfl @CPAlejandro