Erasing windows update option in wrong cases #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpRegalado
approved these changes
Aug 18, 2021
frankeros
force-pushed
the
fix/3566-windows-update-in-linux-agent-inventory
branch
from
e4af80d
to
76ba745
Compare
frankeros
suggested changes
Aug 18, 2021
| @@ -1906,7 +1906,7 @@ export class WazuhReportingCtrl { | |||
| ] | |||
| } | |||
| }, | |||
| { | |||
| agentOs === 'windows' && { | |||
There was a problem hiding this comment.
this is a bad implementation, is not a good practice using a ternary in an array definition
please use a different approach, maybe inserting after the declaration of the array with a conditional
also, check if this endpoint is used for another SO but windows
There was a problem hiding this comment.
I change it using your suggestions. Thanks you!
…tps://github.com/wazuh/wazuh-kibana-app into fix/3566-windows-update-in-linux-agent-inventory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
We disabled Windows Update part of Inventory PDF in agents with an operative system different from Windows.
To test it, go to Agents, click an agent without Windows, go to Inventory Section and generate a PDF. Then go to the end of that and see if Windows Update section appers.
If you can, try as well with a Windows agent to check that in this case, this section appears.
Closes #3566