Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed vulnerability flyout #3593

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Fixed vulnerability flyout #3593

merged 4 commits into from
Sep 3, 2021

Conversation

mpRegalado
Copy link
Member

Set the implicit filters of the vulnerabilities flyout to be populated dynamically depending on the available data.
closes #3587

To test

  1. Set up an environment with vulnerabilty scanner enabled and a windows agent
  2. Enable sample data
  3. Make sure in the discover tab that the vulnerability CVE-2020-0678 has alerts for the selected agent
  4. See the details in the vulnerability inventory for CVE-2020-0678 and see that it contains the same alerts as in step 3

@mpRegalado
Fixed vulnerability flyout
41bfac1 
Set the implicit filters of the vulnerabilities flyout to be populated dynamically depending on the available data.
@mpRegalado mpRegalado self-assigned this Sep 2, 2021
@mpRegalado mpRegalado changed the base branch from master to 4.2-7.10 September 2, 2021 19:14
@frankeros
Copy link
Contributor

CR: LGTM!
Testing: Pass
image

Desvelao
Desvelao approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✅
Testing ✅
image

Not related to the PR, but there is a problem with the column width for the button that expand the row.

@mpRegalado mpRegalado merged commit 0630666 into 4.2-7.10 Sep 3, 2021
@mpRegalado mpRegalado deleted the bugfix/3587_empty-vulnerability-fields branch September 3, 2021 08:46
@frankeros frankeros mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankeros frankeros frankeros approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@mpRegalado mpRegalado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No event results when a vulnerability is missing a field.
3 participants
@mpRegalado @frankeros @Desvelao