Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply enhance #3622 -> Add filter bar on Network ports table #3639

Merged
merged 3 commits into from Nov 5, 2021

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Sep 30, 2021

The filter bar has been enabled on the table

Closes #3622

How to test

Steps to reproduce

  1. Open Kibana app and go to Agents tab, select any agent and open Inventory data option.
  2. Try different filters on the Network ports table, using its search bar.

Test retrocompatibility

Given the browser is in wazuh app

  • When the user navigates to agents/agent/inventory Data
  • Then the configuration panel does not show an api selector toggle

Check Network search bar

  • Given Inventory data of an agent showed
  • When the user go to Network table
  • Then a search bar with the text: "Filter network ports..." will be in the Network table

Check filters in Network table

  • Given Inventory data of an agent showed
  • When the user introduce "tcp" in the search bar of Network ports
  • Then all the rows of the Protocol colunm will have the word "tcp"

Expected result

  1. The search bar shows on the table.
  2. The table filters the content by the text introduced on the search bar.

@AlexRuiz7 AlexRuiz7 linked an issue Sep 30, 2021 that may be closed by this pull request
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing: LGTM ✔️
Just missing the changelog

@AlexRuiz7 AlexRuiz7 changed the base branch from 4.2-7.10 to 4.3-7.10 October 1, 2021 08:58
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@frankeros frankeros merged commit 6aad89a into 4.3-7.10 Nov 5, 2021
@frankeros frankeros deleted the enhance/add-search-bar-to-inventory-data-table branch November 5, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory data does not have filter on Network ports table
6 participants