Fixing error that shows we're using X-Pack when we have Basic #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Nov 24, 2021
server/controllers/wazuh-api.ts
Outdated
| @@ -1060,7 +1060,7 @@ export class WazuhApiCtrl { | |||
|
|
|||
| const disabledRoles = ( await getConfiguration() )['disabled_roles'] || []; | |||
| const logoSidebar = ( await getConfiguration() )['customization.logo.sidebar'] || 'icon_blue.png'; | |||
| const wazuhSecurity = SecurityObj(context.wazuh.plugins); | |||
| const wazuhSecurity = await SecurityObj(context.wazuh.plugins, context); | |||
There was a problem hiding this comment.
nitpick: use the context.wazuh.security instead of create another security object.
Desvelao
reviewed
Nov 24, 2021
Comment on lines
24
to
32
| try { | ||
| const responseCurl = await context.core.elasticsearch.client.asInternalUser.transport.request( | ||
| params | ||
| ); | ||
| } catch (error) { | ||
| return !!opendistroSecurityKibana | ||
| ? new OpendistroFactory(opendistroSecurityKibana) | ||
| : new DefaultFactory(); | ||
| } |
There was a problem hiding this comment.
nitpick: The request to check if X-Pack is enabled should be done only if security plugin is installed.
…-X-Pack' of github.com:wazuh/wazuh-kibana-app into fix/Fixing-error-with-Basic-that-shows-like-we're-using-X-Pack
|
sortiz1191
approved these changes
Nov 24, 2021
…hows-like-we're-using-X-Pack
MauGaP
deleted the
fix/Fixing-error-with-Basic-that-shows-like-we're-using-X-Pack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOULD_TEST=FALSE
Hi guys,
We are fixing a bad behaviour that's shows to Wazuh app like we are using X-Pack when we have Basic Security.
To test it:
Test with X-Pack, Basic and ODFE and be sure that the app is receiving properly which security plugin you are using.
Close this comment