Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing blank screen before Health-Check #3700

Merged
merged 2 commits into from Nov 30, 2021

Conversation

CPAlejandro
Copy link
Contributor

@CPAlejandro CPAlejandro commented Nov 30, 2021

In this PR we solve the bug that caused a blank tab to be shown before even passing the Health-Check, for this we have returned to the state of promises that was used, since when integrating a try catch strategy, we found this failure .
Closes #3699

@CPAlejandro CPAlejandro self-assigned this Nov 30, 2021
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CPAlejandro CPAlejandro merged commit e67272b into 4.3-7.10 Nov 30, 2021
@CPAlejandro CPAlejandro deleted the Fixing-blank-screen-before-Health-Check branch November 30, 2021 09:22
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.97% ( 1443 / 36353 )
Branches 1.6% ( 453 / 28398 )
Functions 2.91% ( 259 / 8891 )
Lines 4.02% ( 1398 / 34741 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants