Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Flyouts in Kibana 7.14.2 #3708

Merged
merged 5 commits into from Dec 17, 2021
Merged

Conversation

CPAlejandro
Copy link
Contributor

Fixing error in the flyout, that when clicking inside them, the flyout was closed due to an unintended behavior of EuiOutsideClickDetector. Fixed changing this Eui component to a prop in all EuiFlyouts.

To test it, you would need to go to all the flyouts of the app and check that they work correctly.

@CPAlejandro CPAlejandro added the type/bug Bug issue label Dec 3, 2021
@CPAlejandro CPAlejandro self-assigned this Dec 3, 2021
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao
Copy link
Member

Changes

  • Resolved the conflicts with the base branch

@eze9252 eze9252 added the 4.3 label Dec 17, 2021
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST ✔️

@eze9252 eze9252 merged commit efb8703 into 4.3-7.10---RC1 Dec 17, 2021
@eze9252 eze9252 deleted the Fixing-Flyouts-in-Kibana-7.14 branch December 17, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants