[FIX] [TELEMETRY] Hide the banner #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hide the telemetry banner from UI and set a flag in the saved object that controls if the banner was seen and dismissed - Changed the `wazuh` `public` `start` method to sync intead of `async` function
2 tasks
2 tasks
asteriscos
requested changes
Dec 9, 2021
… be mounted. Note the requirement to access to the app to hide and dissmiss the telemetry notice. This means the banner is visible while the user doesn't open the Wazuh app if the notice wasn't dismissed.
ChangesNow the telemetry banner is hidden and set the flag of the saved object when the frontend of the Wazuh app is to be mounted. This means that the banner is visible if it was not dismissed before. |
gabiwassan
added a commit
that referenced
this pull request
Dec 16, 2021
* doc: update default package * Fixed compatibility wazuh 4.2 - kibana 7.13.4 (#3653) * Fixed compatibility wazuh 4.2 - kibana 7.13.4 * Changed xDomain in elastic chart * Added await in getSearchRequestBody * Updated CHANGELOG Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Franco Charriol <franco.charriol@wazuh.com> * Fixed interative register windows agent screen error (#3654) * Fixed interative register windows agent screen error * Added toLowercase * Updated CHANGELOG * Update CHANGELOG.md Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Franco Charriol <franco.charriol@wazuh.com> * Update CHANGELOG.md * fix: missing async * Fix missing import on build for kibana 7.14 (#3665) * changed import of saved searches * local copy of legacy/vis_update_state * Fixed breadcrumbs style compatibility for Kibana 7.14.2 (#3668) * Parcial breadcrumb style fix * Improved beadcrumb styling and text overflow * Added changelog * Fix remove token on logout kibana 7.13 (#3670) * Fixing EuiPannels in Overview Sections and disabled text in WzMenu (#3674) * Fixing EuiPannels in Overview Sections * Fixing disabled text in Wz Menu * Fix/3673 fixing double flyout clicking in a policy (#3676) * Fixing disabled buttons in wz menu * Fixing double flyout * Fixed Group Configuration and Management configuration error after trying to going back after you save (#3672) * Solving error * Adding Changelog.md * Fixing bug editting user * Fixed kibana settings conflict on health check (#3678) * [FIX] [Compatibility] Get the valid index patterns to use in the app in Kibana 7.10.2 - 7.13.4 (#3681) * fix(compatibility): Manage how to get the index pattern data and refresh the fields for Kibana 7.10.2 and Kibana >=7.11.0 - Added a function to check if the Kibana version (`kibana.version` property of `package.json`) satisfies a specific version. - Modified some logic when getting the index patterns or refreshing them to be compatible with 7.10.2 and 7.13.4. An Kibana change modified as getting the index pattern fields. - Added a toast when an unknown index pattern field is detected in Kibana >7.10.2 in Modules/<MODULE>/(Dashboard/Events) and set its life time to 5 minutes. Note: tested with Kibana 7.10.2 and 7.13.4 but should works in Kibana 7.11.x and 7.12.x * changelog: Add PR to changelog * fix(compatibility): Replaced references from 7.10.2 to 7.11 in the fixes for the compatibility to get the index pattern data and their fields and refresh them * bump: Wazuh 4.2.5 * Replaced window location after logout * Updated CHANGELOG * [FIX] [TELEMETRY] Hide the banner (#3709) * fix(telemetry): Hide the telemetry banner - Hide the telemetry banner from UI and set a flag in the saved object that controls if the banner was seen and dismissed - Changed the `wazuh` `public` `start` method to sync intead of `async` function * changelog: Add PR to changelog * fix: Add semicolon * fix(telemetry): Hide the telemetry banner when the app frontend is to be mounted. Note the requirement to access to the app to hide and dissmiss the telemetry notice. This means the banner is visible while the user doesn't open the Wazuh app if the notice wasn't dismissed. * [FIX] [HEALH CHECK] Fix `listValidIndexPatterns.find is not a function` error (#3698) * fix(health-check): Fix "listValidIndexPatterns.find is not a function" error - Ensure the `attributes.fields` exists in the index pattern data before parsing it - Removed returning with error message or error in `SavedObjects.getListOfIndexPatterns` and `SavedObjects.getListOfWazuhValidIndexPatterns` * changelog: Add PR to changelog * added delay into request deleteToken Co-authored-by: Franco Charriol <francocharriol@gmail.com> Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Franco Charriol <franco.charriol@wazuh.com> Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com> Co-authored-by: Alejandro Cuéllar Peinado <alejandro.cuellar@wazuh.com> Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> Co-authored-by: Matias Ezequiel Moreno <matiasezequielmoreno@MacBook-Pro-de-Matias.local> Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hides the
telemetrybanner from UI and saves that the banner was seen to avoid the banner is displayed on the next times.The status of if the banner was seen/dismissed of
telemetrybanner is stored in a saved object. This is persistent. For new environments, the attribute that controls this is not stored so the banner is displayed, if use theDismissbutton, store the flag in the saved objects for next times.Moreover, the status is saved as a property i the
telemetryplugin.Changed
wazuhpublicstartmethod to sync instead ofasyncfunctionTests
telemetrybanner is not set, so this is displayed. The PR, removes the banner from UI and sets the flag in the saved object and this should not be displayed.Note:
Delete the
telemetryobject so this should be displayed again, or remove the indices.kibana*(where the telemetry saved object is stored) so it could test it again.