Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] [Office365] [GitHub] Update data when clearing the query filter #3722

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 9, 2021

…r in the search bar and the data is not updated

  • Now uses useQueryManager instead of useQuery

Description

This PR solves when clearing the query filter in the search bar of Panel tab of modules Office 365 and GitHub. See #3713 (comment)

Changes

  • Replace the hook used by useQueryManager instead of useQuery.

Tests

  • Add a query filter in the search bar of Panel tab of modules Office 365 and GitHub and apply the searching, after clearing the query string and updating the search, the data should be updated.

…r in the search bar and the data is not updated

  - Now uses `useQueryManager` instead of `useQuery`
@Desvelao Desvelao added the type/bug Bug issue label Dec 9, 2021
@Desvelao Desvelao self-assigned this Dec 9, 2021
@Desvelao Desvelao changed the title [Panel] [Office365] [GitHub] Updates data when clearing the query filter [Panel] [Office365] [GitHub] Update data when clearing the query filter Dec 9, 2021
@Desvelao Desvelao linked an issue Dec 13, 2021 that may be closed by this pull request
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eze9252 eze9252 merged commit 1649a81 into 4.3-7.10---RC1 Dec 16, 2021
@eze9252 eze9252 deleted the fix/3713-office365-github-no-update-data-with-no-query-filter-in-search-bar branch December 16, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Office 365 and Github Advanced Query Bar doesn't clear filters
2 participants